Skip to content

Conversation

@chenopis
Copy link
Collaborator

@chenopis chenopis commented Oct 2, 2025

@chenopis chenopis self-assigned this Oct 2, 2025
@chenopis chenopis marked this pull request as draft October 2, 2025 21:10
@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Documentation preview

https://nvidia.github.io/cloud-native-docs/review/pr-268

@chenopis chenopis force-pushed the dev-25.10.0 branch 3 times, most recently from 01863c2 to 19e7747 Compare October 14, 2025 00:21
@chenopis chenopis force-pushed the dev-25.10.0 branch 2 times, most recently from 915684c to 42cc2a3 Compare October 20, 2025 18:22
Copy link
Contributor

@cdesiniotis cdesiniotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a first pass. Planning to do a more detailed one tomorrow. I would like to help with some of the content, especially the CDI page. Let me know if I should contribute directly to this PR or in a separate PR.

By default this will point to ``/etc/containerd/config.toml`` (the default
location for ``containerd``). It should be customized if your ``containerd``
By default this will point to ``/var/snap/microk8s/current/args/containerd-template.toml``
(the default location for ``containerd``). It should be customized if your ``containerd``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change needs to be reverted. /etc/containerd/config.toml is still the default configuration file location for containerd. We need to revert most (if not all) of the changes in this section.

What does need to change is the following:

  • The descriptions for some of these toolkit envvars may need to be slightly updated. (I can help with the content changes here)
  • The install procedure for microk8s needs to be updated to align with what is stated in https://nvbugspro.nvidia.com/bug/5541760

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pushed an update for this.

chenopis and others added 10 commits October 22, 2025 15:53
Signed-off-by: Abigail McCarthy <[email protected]>
* 25.3 Add patch version columns

Signed-off-by: Andrew Chen <[email protected]>

* Update README.md for GPU Operator tag instructions

Signed-off-by: Andrew Chen <[email protected]>

* Add flat-table extension and update container

Signed-off-by: Andrew Chen <[email protected]>

* fix note

Signed-off-by: Andrew Chen <[email protected]>

* Fix table formatting

Signed-off-by: Andrew Chen <[email protected]>

---------

Signed-off-by: Andrew Chen <[email protected]>
Signed-off-by: Andrew Chen <[email protected]>
a-mccarthy and others added 4 commits October 25, 2025 01:15
Signed-off-by: Abigail McCarthy <[email protected]>
Signed-off-by: chenopis <[email protected]>
Signed-off-by: Abigail McCarthy <[email protected]>
Signed-off-by: chenopis <[email protected]>
Signed-off-by: Abigail McCarthy <[email protected]>
Signed-off-by: chenopis <[email protected]>
* update documentation for NLS licensing token use for secret

Signed-off-by: Shiva Kumar (SW-CLOUD) <[email protected]>
Signed-off-by: Abigail McCarthy <[email protected]>

* Minor changes for style guide compliance

Signed-off-by: Andrew Chen <[email protected]>

update documentation for NLS licensing token use for secret

Signed-off-by: Shiva Kumar (SW-CLOUD) <[email protected]>
Signed-off-by: Abigail McCarthy <[email protected]>

---------

Signed-off-by: Shiva Kumar (SW-CLOUD) <[email protected]>
Signed-off-by: Abigail McCarthy <[email protected]>
Co-authored-by: Shiva Kumar <[email protected]>
Signed-off-by: chenopis <[email protected]>
a-mccarthy and others added 2 commits October 27, 2025 09:50
Signed-off-by: Abigail McCarthy <[email protected]>

Co-authored-by: Christopher Desiniotis <[email protected]>
@a-mccarthy a-mccarthy marked this pull request as ready for review October 27, 2025 16:08
a-mccarthy and others added 2 commits October 27, 2025 11:00
Signed-off-by: Abigail McCarthy <[email protected]>
Signed-off-by: Andrew Chen <[email protected]>
Signed-off-by: chenopis <[email protected]>
Signed-off-by: Abigail McCarthy <[email protected]>

Co-authored-by: Tariq <[email protected]>
Co-authored-by: Christopher Desiniotis <[email protected]>
Signed-off-by: Abigail McCarthy <[email protected]>
@a-mccarthy a-mccarthy merged commit 3e11d27 into main Oct 27, 2025
2 checks passed
@a-mccarthy a-mccarthy deleted the dev-25.10.0 branch October 27, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants